Replace deprecated datetime.utcnow() with datetime.now(timezone.utc) - #340
Draft
sidewinderzz wants to merge 1 commit into
Draft
sidewinderzz wants to merge 1 commit into
sidewinderzz wants to merge 1 commit into
Conversation
datetime.datetime.utcnow() has been deprecated since Python 3.12 and emits a DeprecationWarning on every SRP authentication. Switch the two call sites in aws_srp.py (and the one in tests.py) to the recommended timezone-aware datetime.now(timezone.utc). The formatted Cognito timestamps are unchanged: both helpers only read weekday/month/day/time/year fields, which are identical for the naive and aware values. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
This one would be good to add. Also docs could be updated. I've been on 3.13 without issues. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datetime.datetime.utcnow()has been deprecated since Python 3.12 and emits aDeprecationWarningon every SRP login. This switches the two call sites inaws_srp.py(process_challenge,process_device_challenge) and one intests.pytodatetime.now(timezone.utc), ahead of its eventual removal.No behavior change
The Cognito timestamp strings are byte-identical: both paths only read weekday/month/day/time/year, which match for the naive and aware values (verified under freezegun, including single-digit days).
Testing (Python 3.14.5)
pytest tests.py: 17 passed with-W errorfor the utcnow deprecation (before this change: 1 failed on it)🤖 Generated with Claude Code