Add Ukrainian, Vietnamese and Turkish translations - #169
Merged
Conversation
Adds the three new catalogs to _LANG_NAMES so they are selectable via /settings, and updates the i18n catalog-count tests 15 -> 18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three more UI languages: Ukrainian (uk), Vietnamese (vi) and
Turkish (tr). Catalog count goes 15 → 18.
Unlike the previous batch, these were picked from actual usage rather than a
world-population ranking. A read-only query against the production
users.language_codecolumn (6,439 users) put them as the three largest localeswith no catalog:
Everything below these drops to ko 15, ms 13, nl 13, th 11 and then single
digits across 40 distinct codes, so this is where the returns flatten out.
Coverage of users with a known language goes from ~96.3% to ~98.3%.
Purely additive — no behaviour change. Each language is one TOML catalog plus
one entry in
_LANG_NAMESfor the/settingspicker; auto-detection offTelegram's
language_codestarts working immediately.Verification
Each catalog was checked against
en.tomlfor identical key sets and ordering,identical
{placeholder}sets per key, identical HTML tag sequences, matching\ncounts and no untranslated leftovers._LANG_NAMESand the shipped*.tomlfiles are asserted to be the same set.Full local gate green:
ruff check,ruff format --check,ty check,pytest(558 passed).