Open
Conversation
joseph-robertson
commented
Jan 7, 2026
joseph-robertson
commented
Jan 7, 2026
…tal and Net for each unit.
joseph-robertson
changed the base branch from
master
to
battery-resilience-refactor
11 tasks
…HPXML into unit-fuel-meters # Conflicts: # HPXMLtoOpenStudio/measure.xml
shorowit
reviewed
Feb 10, 2026
… comments, additional properties, output section names.
shorowit
reviewed
Feb 12, 2026
Contributor
shorowit
left a comment
shorowit
left a comment
There was a problem hiding this comment.
Great job addressing my previous comments. I made my way through the rest of the code changes, this is looking awfully good -- though I don't really understand some of the logic in the create_custom_unit_meters method (see comment below about walking through together).
Comment on lines
1581
to
1591
| # The "output variables" returned by get_object_outputs_by_key for interior/exterior lights are actually meter names. | ||
| # Meter name "interior lighting:InteriorLights:Electricity", e.g., includes all "UNITX_INTERIOR_LIGHTING:Lights Electricity Energy". | ||
| # | ||
| # FIXME: We *could*, alternatively, switch to zone level (e.g., "interior lighting:InteriorLights:Electricity:Zone:UNIT1_CONDITIONED_SPACE") | ||
| # like we already use for InteriorEquipment (e.g., "misc plug loads:InteriorEquipment:Electricity:Zone:UNIT1_CONDITIONED_SPACE"). | ||
| if output_var.include? 'InteriorLights:Electricity' | ||
| output_var = 'Lights Electricity Energy' | ||
| end | ||
| if output_var.include? 'ExteriorLights:Electricity' | ||
| output_var = 'Exterior Lights Electricity Energy' | ||
| end |
Collaborator
Author
There was a problem hiding this comment.
@shorowit Does this help to clarify #2138 (comment)?
7 tasks
joseph-robertson
changed the base branch from
master
to
ext-lights-elec-equip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Addresses #1499. Adds custom meters to calculate energy use for each dwelling unit.
Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run