Add stacklevel to warnings.warn() calls #476
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify stacklevel parameter in all warnings.warn() calls to ensure warning messages point to user code rather than rdtools internals: - stacklevel=2: For public functions/methods called directly by users - stacklevel=3: For private helper methods called by public methods Files updated: - analysis_chains.py: 6 warnings - filtering.py: 2 warnings - soiling.py: 4 warnings - plotting.py: 3 warnings - normalization.py: 1 warning - availability.py: 1 warning - clearsky_temperature.py: 2 warnings
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fix-numpy-and-pandas-compatibility #476 +/- ##
===================================================================
Coverage 96.14% 96.14%
===================================================================
Files 12 12
Lines 2280 2280
===================================================================
Hits 2192 2192
Misses 88 88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The stacklevel parameter changes which line of code is shown in warning tracebacks. Add regex rule to sanitize these lines so tests pass regardless of stacklevel values.
mdeceglie
approved these changes
Feb 4, 2026
martin-springer
changed the base branch from
fix-numpy-and-pandas-compatibility
to
development
martin-springer
changed the base branch from
development
to
fix-numpy-and-pandas-compatibility
martin-springer
changed the base branch from
fix-numpy-and-pandas-compatibility
to
development
martin-springer
changed the base branch from
development
to
fix-numpy-and-pandas-compatibility
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify stacklevel parameter in all warnings.warn() calls to ensure warning messages point to user code rather than rdtools internals:
Closes #327
Files updated:
Checklist
[ ] Code changes are covered by tests[ ] Code changes have been evaluated for compatibility/integration with TrendAnalysis[ ] New functions added to__init__.py[ ] API.rst is up to date, along with other sphinx docs pages