Add disk space monitoring and pause pickup#1251
Open
cfkoehler wants to merge 2 commits intoNationalSecurityAgency:mainfrom
Open
Add disk space monitoring and pause pickup#1251cfkoehler wants to merge 2 commits intoNationalSecurityAgency:mainfrom
cfkoehler wants to merge 2 commits intoNationalSecurityAgency:mainfrom
Conversation
dev-mlb
approved these changes
Dec 16, 2025
memny
approved these changes
Feb 23, 2026
Collaborator
memny
left a comment
memny
left a comment
There was a problem hiding this comment.
Looks like it works. Unless there's a reason for the current organization, consider consolidating all the logic for setting up the DiskSpaceMonitor behind it's constructor. Right now it's spread between PickUpPlace.configureDiskSpaceMonitoring(), The setters on the DiskSpaceMonitor builder and the build function.
| } | ||
|
|
||
| diskSpaceMonitor = builder.build(); | ||
| diskSpaceMonitor.addListener(new DiskSpaceListener() { |
Collaborator
There was a problem hiding this comment.
Why not just make PickUpPlace implement DiskSpaceListener directly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.