Skip to content

fix: deprecated error in tests #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

SRWieZ
Copy link
Member

@SRWieZ SRWieZ commented Feb 24, 2025

Fixing a deprecated error in the test suit

Capture d’écran 2025-02-24 à 13 33 50

@PeteBishwhip PeteBishwhip requested a review from a team February 24, 2025 13:05
@SRWieZ SRWieZ force-pushed the fix-deprecated-error-in-tests branch from d1787d4 to 657620e Compare February 24, 2025 14:49
@SRWieZ
Copy link
Member Author

SRWieZ commented Feb 24, 2025

Just rebased on main to validate that this PR and #500 are both fixing the test suite 🎉

Copy link
Member

@PeteBishwhip PeteBishwhip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do my eyes deceive me or are all the tests passing? 👀

Amazing work!

Take my approval with love!

@PeteBishwhip PeteBishwhip requested a review from a team February 24, 2025 14:57
Copy link
Contributor

@gwleuverink gwleuverink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤌

@SRWieZ SRWieZ merged commit 0ff6ae6 into main Feb 24, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants