Skip to content

fix: initialize properties in Alert class #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

fix: initialize properties in Alert class #529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/Alert.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,21 @@

class Alert
{
protected ?string $type;
protected ?string $type = null;

protected ?string $title;
protected ?string $title = null;

protected ?string $detail;
protected ?string $detail = null;

protected ?array $buttons;
protected ?array $buttons = null;

protected ?int $defaultId;
protected ?int $defaultId = null;

protected ?int $cancelId;
protected ?int $cancelId = null;

final public function __construct(protected Client $client) {}

public static function new()
public static function new(): self
{
return new static(new Client);
}
Expand Down
1 change: 1 addition & 0 deletions src/Facades/Alert.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use Illuminate\Support\Facades\Facade;

/**
* @method static static new()
* @method static static type(string $type)
* @method static static title(string $title)
* @method static static detail(string $detail)
Expand Down
Loading