-
-
Notifications
You must be signed in to change notification settings - Fork 19
feat(android): implement BorderDrawable outline #158
base: master
Are you sure you want to change the base?
Conversation
android/widgets/src/main/java/org/nativescript/widgets/BorderDrawable.java
Outdated
Show resolved
Hide resolved
|
test |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Hi - could we get a status update on this PR? Getting pinged about it regularly. |
|
test |
|
@edusperoni our QAs identified a failing ui test triggered by this change: |
|
Can be reproduced with this xml markup (correct behavior is that there shouldn't be any grayish left/right border): <Page class="page"
navigatingTo="onNavigatingTo"
xmlns="http://schemas.nativescript.org/tns.xsd">
<ActionBar class="action-bar">
<Label class="action-bar-title" text="Home"></Label>
</ActionBar>
<GridLayout rows="*,*,*" columns="*,*,*">
<Button row="1" col="1" textWrap="true" text="border-width: 5 0; border-color: black;"
style="border-width: 5 0; border-color: black;" />
</GridLayout>
</Page> |
|
Hey @edusperoni, |



PR Checklist
What is the current behavior?
BorderDrawable does not have an outline
What is the new behavior?
BorderDrawable has an outline
Provides initial support for NativeScript/NativeScript#550
Are there any tests to run?