Skip to content
This repository was archived by the owner on Mar 21, 2019. It is now read-only.

Conversation

@edusperoni
Copy link

PR Checklist

What is the current behavior?

BorderDrawable does not have an outline

What is the new behavior?

BorderDrawable has an outline

Provides initial support for NativeScript/NativeScript#550

Are there any tests to run?

@manoldonev
Copy link
Contributor

test

@etabakov
Copy link
Contributor

etabakov commented Mar 1, 2019

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Mar 1, 2019
@cla-bot
Copy link

cla-bot bot commented Mar 1, 2019

The cla-bot has been summoned, and re-checked this pull request!

@rdlauer
Copy link

rdlauer commented Mar 15, 2019

Hi - could we get a status update on this PR? Getting pinged about it regularly.

@SvetoslavTsenov
Copy link
Contributor

test

@manoldonev
Copy link
Contributor

@edusperoni our QAs identified a failing ui test triggered by this change:

Actual:
actual

Diff:
diff

Expected:
expected

@manoldonev
Copy link
Contributor

Can be reproduced with this xml markup (correct behavior is that there shouldn't be any grayish left/right border):

<Page class="page"
    navigatingTo="onNavigatingTo"
    xmlns="http://schemas.nativescript.org/tns.xsd">

    <ActionBar class="action-bar">
        <Label class="action-bar-title" text="Home"></Label>
    </ActionBar>

    <GridLayout rows="*,*,*" columns="*,*,*">
        <Button row="1" col="1" textWrap="true" text="border-width: 5 0; border-color: black;"
            style="border-width: 5 0; border-color: black;" />
    </GridLayout>
</Page>

@SvetoslavTsenov
Copy link
Contributor

SvetoslavTsenov commented Mar 21, 2019

Hey @edusperoni,
I want to notify you that the NativeScript/tns-core-modules-widgets repository is being moved to the NativeScript/NativeScript repository in an effort to streamline the maintenance and the QA processes. The tns-core-modules-widgets repository will be archived soon. We advise you to open a new PR in the NativeScript/NativeScript with the suggested changes and we will be happy to review it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants