Compute Solve traits from types as args #2101
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My motivation for this is to be able to set a concrete type in the
@attr Any
call in https://github.com/oscar-system/Oscar.jl/pull/4915/files#diff-88ef12a4e6f091b2cc3dd521d7c8be444dab854cb7aef78f6837778a274315ffR489 (something along the lines of@attr solve_context_type(base_ring_type(M))
).I also copied over the two fallbacks (for
::Any
and for::DataType
) over from all of the similar functions likebase_ring_type
and then removed some obsolete methods.@joschmitt does this change make sense to you?