Integrating ALTQ in NPF #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emmankoko
force-pushed
the
npf_altq
branch
7 times, most recently
from
c7d1744 to
e06168a
Compare
altq communicate to pf through pf_altq queue structures. similar is done for npf and being used to replace pf's pf_altq. npf_altq fileds are compatible with struct pf_altq as they represent a complete queue structure. a needs-flag is set on npf to produce a npf.h during config in the kernel directory which will set optional compilation for npf related code in altq. it is also handled at runtime in the npf module.
includes the queue structure field and a trace of the number of queues being loaded into the kernel and make npf_altq available in include directory for use in altq framework
it is implemented to compute all params of queues for any kind of scheduler
checks: first checks if the queue obeys best practices(having a default queue etc) checks if the referenced queue is defined in the queues then sets the queue to queue nvpair in the rules nvlist.
Emmankoko
force-pushed
the
npf_altq
branch
2 times, most recently
from
fc2accf to
470a691
Compare
starting ALTQ is fully handed over to the kernel. when you start NPF, it checks if altq is loaded and not already running. if ALTQ is already running, it ignores it.
altq is disabled when you stop npf. it is handled internally in kerneland checks if altq is running. in npf, no filtering no queueing so why should queueing be active whiles filtering is disabled?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
altq communicate to pf through pf_altq queue structures. similar is done for npf and being used to replace pf's pf_altq. npf_altq fileds are compatible with struct pf_altq as they represent a complete queue structure.
a needs-flag is set on npf to produce a npf.h during config in the kernel directory which will set optional compilation for npf related code in altq. it is also handled at runtime in the npf module.
@zoulasc @MartinHusemann