Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML Documentation Updates (Again) #58

Closed
wants to merge 3 commits into from
Closed

Conversation

Red-K0
Copy link
Contributor

@Red-K0 Red-K0 commented Oct 16, 2024

PR for adding documentation to various areas of NetCord, primarily focusing on files in the root directory

@KubaZ2
Copy link
Member

KubaZ2 commented Oct 16, 2024

It can be merged with ChannelType.StoreGuildChannel only if it will be handled for receiving.

@Red-K0
Copy link
Contributor Author

Red-K0 commented Oct 16, 2024

Sure, where exactly would I implement that though?

@KubaZ2
Copy link
Member

KubaZ2 commented Oct 16, 2024

it would require creating a channel type for StoreGuildChannel, not sure what properties it has and what interfaces it would implement. I am not sure it's even worth it. It would cause a possibility of breaking changes by Discord as it's undocumented.

@KubaZ2 KubaZ2 marked this pull request as draft October 20, 2024 20:09
- Added documentation comments for all members
- Added and documented `StoreGuildChannel (6)` to enum
Copy link

The documentation preview is available at https://preview.netcord.dev/58.

@KubaZ2 KubaZ2 added this to the 1.0.0 milestone Feb 2, 2025
@Red-K0 Red-K0 closed this Feb 3, 2025
@Red-K0
Copy link
Contributor Author

Red-K0 commented Feb 3, 2025

PR closed, moving to new one (I screwed up the fork)

@KubaZ2 KubaZ2 removed this from the 1.0.0 milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants