update module importer #2636
Open
update module importer #2636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malder08
force-pushed
the
malder/update-module-importer
branch
from
e7b37b5 to
3fc7718
Compare
| raise ImportError(f"No module named '{fullname}'") | ||
|
|
||
| # Replace the standard module with the wrapped module in sys.modules | ||
| sys.modules[fullname] = wrapped_module |
There was a problem hiding this comment.
Looking at the code of how this is used in the import system, I believe we shouldn't be adding stuff to sys.modules. Maybe we can try to do more in create_module and return wrapped_module there and then not do anything in exec_module. I think exec_module is also for reloading which we do not support much right now.
There was a problem hiding this comment.
That makes sense. Originally I was trying not to change the existing logic too much, but I've updated it to have create_module handle everything and it seems much better. Thanks for the help!
malder08
force-pushed
the
malder/update-module-importer
branch
2 times, most recently
from
f70b5a2 to
ed9060d
Compare
|
Netflix internal testing[1388] @ ed9060d |
malder08
force-pushed
the
malder/update-module-importer
branch
from
ed9060d to
f8ee813
Compare
malder08
force-pushed
the
malder/update-module-importer
branch
from
f8ee813 to
05cc612
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the ModuleImporter class to use
find_specinstead offind_moduleandcreate_moduleandexec_moduleinstead ofload_module. In Python 3.12, the fallback that looked for afind_module()method if a meta_path entry didn't have afind_spec()method was removed, so the escape hatch didn't work correctly in this version when running with--environment=conda.