Skip to content

BlackRock: shape parameter for memap#1705

Merged
zm711 merged 4 commits into
NeuralEnsemble:masterfrom
luiztauffer:read-nev-data
May 14, 2025
Merged

BlackRock: shape parameter for memap#1705
zm711 merged 4 commits into
NeuralEnsemble:masterfrom
luiztauffer:read-nev-data

Conversation

@luiztauffer

@luiztauffer luiztauffer commented May 10, 2025

Copy link
Copy Markdown
Contributor

Added a shape parameter to avoid the error #1704

Fix #1704

Comment thread neo/rawio/blackrockrawio.py

@zm711 zm711 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise this seems fine to me.

@zm711 zm711 changed the title shape parameter for memap BlackRock: shape parameter for memap May 10, 2025
@luiztauffer

Copy link
Copy Markdown
Contributor Author

@zm711 I'll still do some checks before merging this, changing it to draft for now

@luiztauffer luiztauffer marked this pull request as draft May 12, 2025 07:40
@luiztauffer luiztauffer marked this pull request as ready for review May 12, 2025 15:57
@luiztauffer luiztauffer requested a review from zm711 May 12, 2025 15:58
@luiztauffer

Copy link
Copy Markdown
Contributor Author

the resulting extracted data seem to be correct

Comment thread neo/rawio/blackrockrawio.py Outdated
@samuelgarcia

Copy link
Copy Markdown
Contributor

OK for me.
Merci Luiz.

Co-authored-by: Zach McKenzie <92116279+zm711@users.noreply.github.com>
Comment thread neo/rawio/blackrockrawio.py
@luiztauffer luiztauffer requested a review from zm711 May 14, 2025 12:11

@zm711 zm711 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good by me. Will merge once tests pass :)

@luiztauffer

Copy link
Copy Markdown
Contributor Author

tests seem to be breaking for plexon at python 3.9, but apparently not related to the changes here

@zm711

zm711 commented May 14, 2025

Copy link
Copy Markdown
Contributor

Yeah this was a previous issue plexon2 only works on windows so we are trying to run it through wine and when running it through wine it often fails to open the file (even the plexon dev's don't know why that happens. I'll try rerunning one more time and if it still fails I'll merge then open an issue to troubleshoot. Normally a re-run or two fixes it.

EDIT: on our main branch it appears to have failed on 3.12 so I don't think this is a python version issue. maybe a wine issue or maybe the normal flakiness of the file failing to open.

@zm711

zm711 commented May 14, 2025

Copy link
Copy Markdown
Contributor

Merging as the test failures are unrelated to this PR. I opened issue #1707 for us to figure out this flakiness and tests passed before the comment (documentation not code change) was added :)

@zm711 zm711 merged commit 5df3403 into NeuralEnsemble:master May 14, 2025
6 of 13 checks passed
@luiztauffer luiztauffer deleted the read-nev-data branch May 14, 2025 12:49
@zm711 zm711 added this to the 0.14.2 milestone May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't read Blackrock nev file - Size of available data is not a multiple of the data-type size.

3 participants