Fix: toTable adds category tables when NWB table is an AlignedDynamicTable#834
Open
ehennestad wants to merge 4 commits into
Open
Conversation
toTable adds category tables when NWB table is an AlignedDynamicTable
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## codex/aligned-dynamic-table-add-category #834 +/- ##
===========================================================================
Coverage ? 95.44%
===========================================================================
Files ? 223
Lines ? 7921
Branches ? 0
===========================================================================
Hits ? 7560
Misses ? 361
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ad0fcb0 to
60d8028
Compare
Add categories to column names Convert categoryTable to Mtable before comparing ids
Added toTable test
a5449bf to
56a9bcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Problem:
A user creates an
IntracellularRecordingsTableand want to inspect it using thetoTablemethod. However, the result only displays the columns of the table but none of the sub-tables (i.e.electrodes,stimuli,responses).Solution:
Add category tables as columns in
tablewhen converting aDynamicTable(AlignedDynamicTable) to a MATLABtableobjectExample:
Before:
Only the
recordings_tagcolumn is present.After:
Each category table is added as a nested table
Note:
This PR surfaced a small detail that was missed in PR #828.
columnsofDynamicTablecan be empty. Therefore, input validation in thegetRowutility function was updated to allow emptycolnamesas input.How to test the behavior?
Checklist
fix #XXwhereXXis the issue number?