refactor(database): eliminate code duplication and cleanup#298
Open
tianrking wants to merge 1 commit intoNevaMind-AI:mainfrom
Open
refactor(database): eliminate code duplication and cleanup#298tianrking wants to merge 1 commit intoNevaMind-AI:mainfrom
tianrking wants to merge 1 commit intoNevaMind-AI:mainfrom
Conversation
- Add shared RepoBaseMixin for common repository methods - Refactor SQLiteRepoBase and PostgresRepoBase to inherit from RepoBaseMixin - Remove deprecated query_cosine function (unused, slower than cosine_topk) - Remove associated _cosine helper function Benefits: - Eliminates ~70 lines of duplicate code - Improves maintainability by centralizing common logic - Removes confusion between query_cosine and cosine_topk - All existing tests pass (syntax validated) Files modified: - src/memu/database/base.py (new) - Shared base repository mixin - src/memu/database/sqlite/repositories/base.py - Now inherits RepoBaseMixin - src/memu/database/postgres/repositories/base.py - Now inherits RepoBaseMixin - src/memu/database/inmemory/vector.py - Removed unused functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benefits:
Files modified: