Skip to content

refactor: 사전 질문 API 스펙 변경 대응 #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mangbaam wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

refactor: 사전 질문 API 스펙 변경 대응 #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions data/src/main/java/com/nexters/boolti/data/network/response/PreQuestionAnswerResponse.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,19 @@ internal data class PreQuestionAnswerDetailResponse(
internal data class PreQuestionAnswerItemResponse(
val preQuestionId: Long,
val question: String,
val description: String?,
val description: String,
val isRequired: Boolean,
val answer: String?,
val answer: String,
val createdAt: String?,
val modifiedAt: String?,
)

internal fun PreQuestionAnswerItemResponse.toDomain() = PreQuestionAnswer(
preQuestionId = preQuestionId,
question = question,
description = description.orEmpty(),
description = description,
isRequired = isRequired,
answer = answer.orEmpty(),
answer = answer,
)

internal fun List<PreQuestionAnswerItemResponse>.toDomains() = map { it.toDomain() }
1 change: 0 additions & 1 deletion ...n/java/com/nexters/boolti/presentation/screen/prequestionedit/PreQuestionEditViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ class PreQuestionEditViewModel @Inject constructor(
private fun submitAnswers() {
val state = uiState.value
val answerRequests = state.answers
.filter { (_, answer) -> answer.isNotBlank() }
.map { (questionId, answer) ->
PreQuestionAnswerRequest(
preQuestionId = questionId,
Expand Down
3 changes: 0 additions & 3 deletions ...tion/src/main/java/com/nexters/boolti/presentation/screen/ticketing/TicketingViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,16 +235,13 @@ class TicketingViewModel @Inject constructor(
if (state.preQuestions.isEmpty()) return

val answers = state.preQuestionAnswers
.filter { (_, answer) -> answer.isNotBlank() }
.map { (questionId, answer) ->
PreQuestionAnswerRequest(
preQuestionId = questionId,
answer = answer,
)
}

if (answers.isEmpty()) return

val request = SubmitPreQuestionAnswersRequest(
reservationId = reservationId,
answers = answers,
Expand Down
Loading