Conversation
enebin
commented
Mar 8, 2026
Member
Author
enebin
left a comment
enebin
left a comment
There was a problem hiding this comment.
diff가 만아보이는데 DTO랑 네트워크 호출 + 컴포넌트땜에 커진 감이 있음.. 컴포넌트 쪽은 코멘트 써놓긴 했는데 어차피 나중에 덮어 쓸 거니까 일단 패스~
FoodDiary/Presentation/Sources/Insight/Components/InsightCategoryStatsView.swift
Show resolved
Hide resolved
kanghun1121
reviewed
Mar 8, 2026
Comment on lines
+197
to
+199
| guard let insightVM = try? container.resolve(InsightVM.self) else { | ||
| fatalError("InsightViewModel not registered") | ||
| } |
Member
There was a problem hiding this comment.
이번에 고도화하면서 VM을 직접 DI에 등록하는거에 대해서 고민을 좀 해봐야 할 듯??
Member
Author
There was a problem hiding this comment.
이거 맥락이 기억이 안나는데 VM을 머 따로 관리하기로 했었나..?
Member
There was a problem hiding this comment.
ViewModel도 .transient 로 해서 괜찮을 거 같긴 하네 큰 문제 생기진 않을 거 같으니까 직접 주입하는 방법으로 일단 가죠!
kanghun1121
reviewed
Mar 8, 2026
kanghun1121
reviewed
Mar 8, 2026
kanghun1121
reviewed
Mar 8, 2026
Member
kanghun1121
left a comment
kanghun1121
left a comment
There was a problem hiding this comment.
고생하셨습니다! 간단한 코멘트 몇 개만 확인해주심 됩니다👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✏️ 변경 내용
인사이트 화면 구현
InsightViewModel추가 및FetchInsightUseCase를 통한 데이터 로딩InsightViewController리팩토링: 로딩/빈 상태/데이터 표시 바인딩 구성InsightPhotoStatsView: 사진 통계InsightCategoryStatsView: 카테고리 통계InsightTopMenuView: 인기 메뉴InsightDiaryTimeStatsView: 기록 시간 통계InsightKeywordsView: 키워드Data / Domain 레이어
Insight엔티티 및InsightError정의InsightRepository프로토콜 및InsightRepositoryImpl구현InsightEndpoint,InsightResponseDTO추가FetchInsightUseCase추가버그 수정
InsightKeywordsViewheight constraint 크래시 수정noAccessToken이 "데이터 부족"으로 오분류되던 문제 수정✅ 체크리스트