Conversation
Test Results32 tests 32 ✅ 0s ⏱️ Results for commit 3152f14. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive set of changes to enhance earnings calculation, reporting, and notification features related to workdays and payroll. The main improvements include the addition of monthly earnings calculation, daily pay computation for workdays, and significant refactoring for better modularity and maintainability. Below are the most important changes grouped by theme:
Earnings Calculation and Reporting:
EarningsCalculatorservice to encapsulate logic for calculating default monthly salary and daily earnings, including handling of work/vacation days and overtime./workdays/earningsinWorkdayControllerto provide monthly earnings data, returning aMonthlyEarningsResponsewith total earnings, default salary, worked minutes, and standard minutes. [1] [2]WorkdayServiceto use the new earnings calculation logic, including computing daily pay for each workday and aggregating monthly earnings. Refactored schedule resolution and response creation for consistency. [1] [2] [3] [4] [5] [6]Salary and Work Minutes Calculation:
SalaryCalculatorwith methods to calculate work minutes (accounting for overnight shifts) and prorated earnings based on actual vs. policy work minutes.LocalTimeandDuration.Notification and Service Refactoring:
com.moa.service.notificationpackage for better modularity and clarity. [1] [2] [3] [4] [5]User-Facing Improvements:
Repository and Query Adjustments:
WorkPolicyVersionRepositoryfor consistency.These changes collectively improve the accuracy and transparency of earnings calculations, provide new reporting capabilities, and improve code organization for future development.…lity