Refactor MonthlyEarningsResponse naming for clarity#25
Merged
Conversation
Test Results32 tests 32 ✅ 0s ⏱️ Results for commit e243cb1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the naming of fields in the
MonthlyEarningsResponsedata class and its usage in theWorkdayService. The new names more accurately reflect the meaning of the data, improving code clarity and maintainability.DTO and Service Response Naming Updates:
MonthlyEarningsResponsefromtotalEarningstoworkedEarningsand fromdefaultSalarytostandardSalaryfor clearer semantics (src/main/kotlin/com/moa/service/dto/MonthlyEarningsResponse.kt).MonthlyEarningsResponseinWorkdayServiceto use the new field names (workedEarningsandstandardSalary) instead of the old ones (totalEarningsanddefaultSalary) (src/main/kotlin/com/moa/service/WorkdayService.kt).