Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: skip testing on ubuntu until 24.04 is avialable on GHA #17

Merged
merged 1 commit into from
May 8, 2024
Merged

CI: skip testing on ubuntu until 24.04 is avialable on GHA #17

merged 1 commit into from
May 8, 2024

Conversation

rursprung
Copy link
Collaborator

the new code now requires std::views which is not yet supported in GCC 13.1 (available on Ubuntu 22.04, the current ubuntu-latest in GHA). as it's quite cumbersome to install GCC 13.2 (which adds support for this and has been released nearly a year ago) the easiest option for now to move forward is to just disable the Ubuntu tests. GHA will soon have the new Ubuntu 24.04 available for beta-testing
(see actions/runner-images#9691) at which point we can try to re-enable it based on the new beta. this should then also enable us to start testing with CLang again.

for the time being tests will only run on Windows against MSVC (which is new enough and supports all needed C++23 features).

@rursprung rursprung requested a review from Nic822 May 5, 2024 22:06
the new code now requires `std::views` which is not yet supported in GCC
13.1 (available on Ubuntu 22.04, the current `ubuntu-latest` in GHA). as
it's quite cumbersome to install GCC 13.2 (which adds support for this
and has been released nearly a year ago) the easiest option for now to
move forward is to just disable the Ubuntu tests. GHA will soon have the
new Ubuntu 24.04 available for beta-testing
(see actions/runner-images#9691) at which point we can try to re-enable
it based on the new beta. this should then also enable us to start
testing with CLang again.

for the time being tests will only run on Windows against MSVC (which is
new enough and supports all needed C++23 features).
@rursprung
Copy link
Collaborator Author

@Nic822 : can you please update the config of the repository and remove the ubuntu build from the list of required builds for PRs (under the branch protection rule)? then this PR can be merged and unblocks #16. thanks & sorry for the inconvenience!

@Nic822 Nic822 merged commit 8517604 into Nic822:master May 8, 2024
1 check passed
@rursprung rursprung deleted the GHA-disable-ubuntu-checks branch May 8, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants