Skip to content

Conversation

@Jaden35
Copy link
Contributor

@Jaden35 Jaden35 commented Aug 14, 2025

Controller input fixed on the Dorm pause menu for regular race and time trial. (All-Nighter Time Trial's controller support on the pause menu worked for me without any changes)

Time Trial Dorm is also added to the build which afaik fixed the back button issue in the Time Trial map select

Controller input fixed on the Dorm pause menu for regular race and time trial. (All-Nighter Time Trial's controller support on the pause menu worked for me without any changes)

Time Trial Dorm is also added to the build which afaik fixed the back button issue in the Time Trial map select
@Jaden35 Jaden35 requested review from a team, LRLogan and StormASC20 as code owners August 14, 2025 17:31
Jaden35 and others added 2 commits August 14, 2025 14:37
I disabled the input manager in outer loop since there's one that's within the karts, and I tried removing and readding the first button selected in the Event System for the other maps. This works on my branch and hopefully it works on the artifact.
@JustinHuang3730
Copy link
Contributor

Please merge from main for working time trial maps, I am not sure if controller input works on main for pausing because I don't have a controller

time trials maps have controller input and navigation
@JustinHuang3730
Copy link
Contributor

main already have time trial ui fixed, I am so confused, I need proper communication. Is time trial stuff on main not working for you? I would like a video of it.

WhispDoor
WhispDoor previously approved these changes Aug 14, 2025
Copy link
Contributor

@WhispDoor WhispDoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

most maps should track a bit better
@JustinHuang3730
Copy link
Contributor

JustinHuang3730 commented Aug 14, 2025

I feel like code that is already done is being done again? Has anyone checked if it is not working on main? Or that the UI is already up to date on main? I made a video that displayed the UI and pause working on the time trial maps. There should be no reason why controller controls wouldn't work if keyboard controls can work unless the input action asset or code stuff gone wrong?

If the UI stuff and controller input is not working on most recent updated main branch I want someone to show me it, otherwise I feel insane because I am trying to communicate, but it doesn't communication is reciprocated?

LRLogan
LRLogan previously approved these changes Aug 14, 2025
Copy link
Collaborator

@LRLogan LRLogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust this will work

@JustinHuang3730
Copy link
Contributor

Yes, it will probably work. What I am complaining about that it has already been done on main, and what this is doing is a repeat of what has already been done and I am trying to say that but it feel like no one is hearing or understanding me so it drives me mad! Like did anyone actually try if main already have all the necessary changes done by a previous pull request that has been merged?!

@LRLogan
Copy link
Collaborator

LRLogan commented Aug 14, 2025

Bug list: Timer broke on campus circuit and GOL, minimap not showing properly on All nighter

@LRLogan LRLogan merged commit 03610b0 into main Aug 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants