Skip to content

RedisBroker: Leave existing max_concurrency values alone #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
0xDEC0DE wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RedisBroker: Leave existing max_concurrency values alone #28

0xDEC0DE wants to merge 1 commit into from

Conversation

@0xDEC0DE
Copy link
Contributor

@0xDEC0DE 0xDEC0DE commented Nov 28, 2023

  • Leave already-set concurrency values alone, always.
  • Fix some unit tests that were throwing InvalidJobSignatureError errors
  • Fix incompatibilties with tox >= 4.0

Fixes: Issue #27

bigjools
bigjools requested changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@bigjools bigjools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the wrong approach, see my last comment on the ticket.

@nisimond
RedisBroker: Leave existing max_concurrency values alone
fdfcfd5 
Leave already-set concurrency values alone, always.

Fixes: Issue NicolasLM#27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bigjools bigjools bigjools requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0xDEC0DE @bigjools @nisimond