Skip to content

Conversation

jainank
Copy link

@jainank jainank commented Feb 12, 2020

Description

Fixed #226 , where isAvailable function in iOS returns generic error rather than specific error

How did you test your changes?

Tested the changes on my personal application.
I tried to run test-ios, but seems like some issue with my simulator which is throwing error to run the app. However when I tested with my production application, it works perfectly.

@NiklasMerz NiklasMerz added this to the 4.0.0 milestone Feb 22, 2020
@NiklasMerz
Copy link
Owner

Rebased. Looks like a breaking changed. Milestone set to next major version

Copy link
Collaborator

@exxbrain exxbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I see codeclimate errors should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iOS - isAvailable function generalize the error code, however authenticate function have proper error code mapping

3 participants