feat(libstore): add AWS SSO support for S3 authentication #14645
+239
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xokdvium
reviewed
Nov 25, 2025
This enables seamless AWS SSO authentication for S3 binary caches without requiring users to manually export credentials. This adds SSO support by calling aws_credentials_provider_new_sso() from the C library directly. It builds a custom credential chain: Env → SSO → Profile → IMDS The SSO provider requires a TLS context for HTTPS connections to SSO endpoints, which is created once and shared across all providers.
Add validation for TLS context and client bootstrap initialization, with appropriate error messages when these fail. The TLS context failure is now a warning that gracefully disables SSO, while bootstrap failure throws since it's required for all providers.
The default (empty) profile case was using CreateCredentialsProviderChainDefault which didn't properly support role_arn/source_profile based role assumption via STS because TLS context wasn't being passed to the Profile provider. This change unifies the credential chain for all profiles (default and named), ensuring: - Consistent behavior between default and named profiles - Proper TLS context is passed for STS operations - SSO support works for both cases
Mic92
reviewed
Dec 1, 2025
| machine.fail(f"nix path-info {pkg}") | ||
| def setup_s3(populate_bucket=[], public=False, versioned=False): | ||
| def setup_s3(populate_bucket=[], public=False, versioned=False, profiles=None): |
Member
There was a problem hiding this comment.
BTW. It would make sense to start adding types here at some point. mypy is enabled in NixOS tests.
xokdvium
reviewed
Dec 1, 2025
Comment on lines
+68
to
+70
| if (!rawProvider) { | ||
| return nullptr; | ||
| } |
Contributor
There was a problem hiding this comment.
This seems unnecessary, considering the createWrapperProvider als does the nullptr check.
| apiHandle.InitializeLogging(logLevel, stderr); | ||
|
|
||
| // Create a shared TLS context for SSO (required for HTTPS connections) | ||
| auto allocator = Aws::Crt::ApiAllocator(); |
Contributor
There was a problem hiding this comment.
Shouldn't this be a member of the class? I'm not sure about the lifetime requirements of the sdk for the allocator.
Comment on lines
+179
to
182
| auto bootstrap = Aws::Crt::ApiHandle::GetOrCreateStaticDefaultClientBootstrap(); | ||
| if (!bootstrap) { | ||
| throw AwsAuthError("failed to create AWS client bootstrap"); | ||
| } |
Contributor
There was a problem hiding this comment.
The bootstrap could also probably be a member and not rely on the singleton bootstrap.
| // including SSO support and proper TLS context for STS-based role assumption. | ||
| Aws::Crt::Auth::CredentialsProviderChainConfig chainConfig; | ||
| auto allocator = Aws::Crt::ApiAllocator(); | ||
| const char * profileName = profile.empty() ? "(default)" : profile.c_str(); |
Contributor
There was a problem hiding this comment.
The default is special-cases by the SDK?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Context
Fixes: #14476
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.