Fix crash when querying realisations without ca-derivations enabled #14674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queryRealisationUncached was crashing with an assertion failure when ca-derivations experimental feature is not enabled, because the SQLite statements for realisations are only initialized when ca-derivations is enabled. Return nullptr (no realisation found) when ca-derivations is disabled, matching the behavior of other CA-related functions like registerDrvOutput which check for the feature before proceeding.
github-actions
bot
added
the
store
Member
|
Yeah I think I had this on some other branch of mine. This is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queryRealisationUncached was crashing with an assertion failure when ca-derivations experimental feature is not enabled, because the SQLite statements for realisations are only initialized when ca-derivations is enabled.
Return nullptr (no realisation found) when ca-derivations is disabled, matching the behavior of other CA-related functions like registerDrvOutput which check for the feature before proceeding.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.