raspberry-pi: remove DigiAMP+ module - #2019
Conversation
doronbehar
left a comment
There was a problem hiding this comment.
In general I am not sure we need to add an entry to this README per every module we convert from a dts source to configtxt module...
ecb6145 to
9a10936
Compare
I removed the dedicated DigiAMP+ README section. The generic overlay documentation remains in the README, and the migration details stay in the removed-option message. |
doronbehar
left a comment
There was a problem hiding this comment.
Be specific & explicit! :)
I was also thinking, maybe we can go ahead and perform all of the config.txt removals in a single PR? I don't expect to encounter merge conflicts if we don't edit the RaspberryPi README. I also think we should reconsider whether we want to not document non-nixos specific details in this README, such as in #### DWC2 USB controller and #### PoE HATs.
9a10936 to
db65e8d
Compare
|
@doronbehar sounds good! I'll send a PR after this one, to migrate all the remaining removals at once. I can remove the specific hardware notes from the README, and update any |
Description of changes
Removes
hardware.raspberry-pi."4".digi-amp-plusin favour of the stockiqaudio-dacplusfirmware overlay throughhardware.raspberry-pi.configtxt.deviceTreeOverlays.The migration keeps the old
autoMuteAmpandunmuteAmpdefaults and behaviour. It usesiqaudio-dacplusinstead ofrpi-digiampplus(because the latter makesunmute_ampdisable auto-mute).Part of #1946.
cc: @doronbehar
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input