Skip to content

raspberry-pi: remove DigiAMP+ module - #2019

Merged
doronbehar merged 1 commit into
NixOS:masterfrom
JamieMagee:raspberry-pi-digiamp-configtxt
Sep 8, 2026
Merged

raspberry-pi: remove DigiAMP+ module#2019
doronbehar merged 1 commit into
NixOS:masterfrom
JamieMagee:raspberry-pi-digiamp-configtxt

Conversation

@JamieMagee

@JamieMagee JamieMagee commented Sep 2, 2026

Copy link
Copy Markdown
Member
Description of changes

Removes hardware.raspberry-pi."4".digi-amp-plus in favour of the stock iqaudio-dacplus firmware overlay through hardware.raspberry-pi.configtxt.deviceTreeOverlays.

The migration keeps the old autoMuteAmp and unmuteAmp defaults and behaviour. It uses iqaudio-dacplus instead of rpi-digiampplus (because the latter makes unmute_amp disable auto-mute).

Part of #1946.

cc: @doronbehar

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@doronbehar doronbehar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I am not sure we need to add an entry to this README per every module we convert from a dts source to configtxt module...

Comment thread raspberry-pi/README.md Outdated
Comment thread raspberry-pi/README.md Outdated
@JamieMagee
JamieMagee force-pushed the raspberry-pi-digiamp-configtxt branch from ecb6145 to 9a10936 Compare September 3, 2026 22:48
@JamieMagee

Copy link
Copy Markdown
Member Author

In general I am not sure we need to add an entry to this README per every module we convert from a dts source to configtxt module...

I removed the dedicated DigiAMP+ README section. The generic overlay documentation remains in the README, and the migration details stay in the removed-option message.

@doronbehar doronbehar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be specific & explicit! :)

I was also thinking, maybe we can go ahead and perform all of the config.txt removals in a single PR? I don't expect to encounter merge conflicts if we don't edit the RaspberryPi README. I also think we should reconsider whether we want to not document non-nixos specific details in this README, such as in #### DWC2 USB controller and #### PoE HATs.

Comment thread raspberry-pi/4/digi-amp-plus.nix Outdated
Comment thread raspberry-pi/4/digi-amp-plus.nix Outdated
@JamieMagee
JamieMagee force-pushed the raspberry-pi-digiamp-configtxt branch from 9a10936 to db65e8d Compare September 8, 2026 03:48
@JamieMagee

Copy link
Copy Markdown
Member Author

@doronbehar sounds good! I'll send a PR after this one, to migrate all the remaining removals at once. I can remove the specific hardware notes from the README, and update any mkRemovedOptionModule notes if need be.

@doronbehar
doronbehar added this pull request to the merge queue Sep 8, 2026
Merged via the queue into NixOS:master with commit 6217378 Sep 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants