tectonic: add online passthru.tests.biber-compatibility #278410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
ofborg
bot
added
10.rebuild-darwin: 0
bryango
force-pushed
the
tectonic-online-tests
branch
from
97ccc2d to
7d8a3b4
Compare
bryango
commented
Jan 3, 2024
doronbehar
reviewed
Jan 3, 2024
bryango
force-pushed
the
tectonic-online-tests
branch
from
476f68a to
1ce6561
Compare
bryango
force-pushed
the
tectonic-online-tests
branch
from
1ce6561 to
fe4860f
Compare
doronbehar
reviewed
Jan 3, 2024
bryango
changed the title
Ah yes, of course hahaha totally missed it 😆 fixed. |
bryango
force-pushed
the
tectonic-online-tests
branch
from
fe4860f to
e3570b9
Compare
|
Great, should be good to go when CI is green. Ping me if I forget. |
The test requires internet access to fetch tectonic's web bundle on demand. This is achieved by abusing a fixed-output derivation, which is capable of internet access. The `tectonic.outPath` is included in the test package name. This ensures that it is always triggered for rebuild when the main derivation changes. Co-authored-by: Doron Behar <[email protected]>
bryango
force-pushed
the
tectonic-online-tests
branch
from
e3570b9 to
58627fa
Compare
Splendid! Thank you! Just fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Implement the (LaTeX + biber) compile test for the tectonic package wrapped with biber.
tectonic.outPathis included in the test package name. This ensures that it is always triggered for rebuild when the main derivation changes.I do have a few concerns about doing this:
tectonic.passthru.testsbe triggered by hydra? Everystaging-nextbuild would probably change tectonic's outPath, which will change the test's name according to this current design. I am not sure (1) whether this would trigger a test rebuild in hydra, and (2) if this happens, whether it would lead to too many test rebuilds. I don't want to accidentally DDoS the upstream server!fetchurl. Is that legal in nixpkgs?This PR follows from discussions in #273740. Note, however, that this PR is independent of the previously discussed web-bundle-locking proposal (which I am also working on upstream, but independent of this PR).
Update:
nixpkgs-reviewas it causes zero rebuild of the main packages.x86_64-*and*-linux(log), still pending onaarch64-darwin.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.