-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
julia_110{,-bin}: 1.10.4 -> 1.10.8 #361201
Conversation
@ofborg build julia_110 julia_110-bin |
Hmm, I wanted to run the julia.withPackages tests but I ran into a problem in the check phase of
|
Likely another openblas bug, I used to hit these on specific cpu models without avx, it went into a broken code path causing incorrect floating point calculations. |
Gotcha. The This is a |
The upstream issue: OpenMathLib/OpenBLAS#4176 |
The thing is, my CPU flags include I found that on my
Could the microarchitecture be getting baked in by whatever Hydra machine compiled LLVM, and then when my machine downloads that, it confuses the CPU version checks on my machine? Julia's |
On my machine:
So that's not the case. |
Hmm, but you might have built LLVM yourself rather than getting it from cache. Does your |
Nah, these are freshly fetched from the cache.
Same, I guess it's just the older llvm versions don't recognize znver4 yet thus falling back to znver3. |
Makes sense, I can confirm that's the case by running However, doing the same with |
julia 1.10.8 released: https://github.com/JuliaLang/julia/blob/v1.10.8/NEWS.md |
The zlib related bug is still present on 1.10.8, we have to live with it. |
I didn't know about this zlib issue. I can build 1.10.8 with your branch but I can't start it on my NixOS machine since it fails to find a system The old 1.10.4 on master works for me on NIxOS. |
Could we |
Let's attempt another solution: reverting the offending commit. I don't know why changes to the llvm build system would affect the build of libunwind, but it is what it is..... |
Okay, that makes things much better:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Hopefully upstream will fix this zlib issue soon?
I think it's half a nixpkgs issue, haven't got time to dig deeper, see JuliaLang/julia#55617 for prior discussions. |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.