Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging-next] sunshine: use boost-186 (fix eval) #366696

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

paparodeo
Copy link
Contributor

boost-185 will be removed soon on master and already is gone on staging-next. Apply the upstream patch
LizardByte/Sunshine@e90b71c

with some minor adjustments to drop windows specific files, files that don't yet exist, and hand apply the changes in process.cpp

fixes eval in staging-next #364438 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@devusb
@thiagokokada

boost-185 will be removed soon on master and already is gone on
staging-next. Apply the upstream patch
LizardByte/Sunshine@e90b71c

with some minor adjustments to drop windows specific files, files that
don't yet exist, and hand apply the changes in `process.cpp`
@philiptaron
Copy link
Contributor

Compared patch to upstream, built package, it will do until the next release!

@philiptaron philiptaron merged commit 41aa486 into NixOS:staging-next Dec 20, 2024
22 of 23 checks passed
@paparodeo paparodeo deleted the sunshine-boost186 branch December 20, 2024 03:01
@devusb
Copy link
Contributor

devusb commented Dec 20, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants