[Backport release-24.11] sunshine: 0.23.1 -> 2025.118.151840 #375532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit aaf03d7)
(cherry picked from commit f626276)
- change text in `wait_for_console_text` to prevent sending curl with
pairing response before moonlight can accept it
- remove "close moonlight" step as next window stays on top in
fullscreen, previous window with pairing result does not interfere
with test. Otherwise it needs OCR or some other way to only do
`send_key("kp_enter")` after "Pairing complete" window is visible.
- add different ways to increase chances of successfull OCR: hide icewm
panel, gxmessage window takes full screen without titlebar or buttons,
black background, white foreground, consolas font,"ABC" text
- add `wait_for_console_text` to only run OCR after window is visible
(cherry picked from commit 46abca2)
(cherry picked from commit d1431a5)
(cherry picked from commit bbc4555)
github-actions
bot
added
6.topic: nixos
niklaskorz
added
the
1.severity: security
|
FYI, cherry-pick-check fails because I had to add the Also, the interim Boost 1.86 compatibility commit was left-out as it only cherry-picked a commit patch already included in 2025.118.151840. The patch was removed by the original update PR. |
github-actions
bot
added
10.rebuild-darwin: 0
devusb
approved these changes
Jan 21, 2025
|
Thanks! |
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #375153 to address GHSA-3hrw-xv8h-9499
Manual backport as the update PR depends on changes from fix #364438 which was not backported to 24.11 yet
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.