Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/inputMethod: remove deprecated option #384782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nixos/inputMethod: remove deprecated option #384782

wants to merge 1 commit into from
+14 −18

Conversation

eclairevoyant
Copy link
Contributor

@eclairevoyant eclairevoyant commented Feb 24, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@eclairevoyant eclairevoyant force-pushed the remove-deprecated-input-option branch from e496316 to 1d748d8 Compare February 24, 2025 14:36
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 24, 2025
@eclairevoyant eclairevoyant force-pushed the remove-deprecated-input-option branch from 1d748d8 to dae485a Compare February 24, 2025 14:40
@github-actions github-actions bot added 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Feb 24, 2025
@eclairevoyant eclairevoyant force-pushed the remove-deprecated-input-option branch 2 times, most recently from 2835c2e to bac288f Compare February 24, 2025 14:43
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Feb 24, 2025
@eclairevoyant eclairevoyant force-pushed the remove-deprecated-input-option branch 2 times, most recently from 38d1ef7 to f04e803 Compare February 24, 2025 14:47
@eclairevoyant
Copy link
Contributor Author

eclairevoyant commented Feb 25, 2025 •
edited
Loading

@ofborg test fcitx5
@ofborg test installed-tests.ibus

@eclairevoyant eclairevoyant force-pushed the remove-deprecated-input-option branch from f04e803 to 1fcda85 Compare February 25, 2025 17:15
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/1016/188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eclairevoyant @nixos-discourse