electron-bin: don't wrap inside libexec

[TomaSajt]

Closes #384854

I am not sure what chrome-sandbox and chrome_crashpad_handler are doing, hopefully they don't actually need to be wrapped.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[booxter]

AFAIU this wrapping hack is not needed once we bump electron as in: #385597 Then we can safely remove it.

[TomaSajt]

We still need to wrap gapps, no?

[booxter]

Oh you are right, I misread the original patch.

I think this is good. One minor comment is that you don't need to ln -s for /bin/electron (nor mkdir -p $out/bin) in the installPhase, so these can be cleaned up.

[booxter]

One question I still don't have an answer to is: with this PR, the /libexec/ electron binary will not be wrapped to fix the 16k issue. AFAIU the /libexec binary is the one that is used to build other apps. Does it mean that all apps that use electron-dist binary will again be affected by the 16k issue (until electron is upgraded)? Are we regressing here?

[TomaSajt]

When packaging an electron based app on linux, we immediately remove the electron that's copied into the package and re-wrap the app using the ${electron}/bin/electron binary.

So, no, currently it won't do anything to impact users.