Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newt, python3Packages.snack: fix darwin linking #385725

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bryango
Copy link
Member

@bryango bryango commented Feb 28, 2025

The python module "snack" (packaged along with "newt") has been failing on darwin (the job succeeds but the python c extension fails to be built and is simply absent). This causes commands that relies on python3Packages.snack to fail, e.g. byobu-config from the byobu package.

This patch uses some linker magic borrowed from

env.NIX_CFLAGS_LINK = lib.optionalString stdenv.hostPlatform.isDarwin "-L${python312}/lib/python3.12/config-3.12-darwin -lpython3.12";
to fix the issue.

This patch only changes the derivation hash on darwin; it should cause zero rebuild on linux. There are 3 commits:

  1. move to by-name and adopt the package
  2. clean up and explicitly add gettext for clang on darwin
  3. fix python module (c extensions) with some linker magic
  4. (new) add a (nonblocking) pythonImportsCheck to passthru.tests
  5. (new) fix up the dylib names in _snack (bug revealed by the previous test)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 28, 2025
@nix-owners nix-owners bot requested a review from natsukium February 28, 2025 04:16
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 28, 2025
configureFlags = lib.optionals stdenv.hostPlatform.isDarwin [
"--disable-nls"
];

makeFlags = lib.optionals (stdenv.buildPlatform != stdenv.hostPlatform) [
Copy link
Member Author

@bryango bryango Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--disable-nls can be removed now as the required gettext is added for darwin.

@bryango bryango marked this pull request as draft February 28, 2025 06:33
@bryango bryango marked this pull request as ready for review February 28, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant