Skip to content

irccat: 0.4.8 -> 0.4.11#407358

Merged
alyssais merged 1 commit into
NixOS:masterfrom
flokli:irccat
May 20, 2025
Merged

irccat: 0.4.8 -> 0.4.11#407358
alyssais merged 1 commit into
NixOS:masterfrom
flokli:irccat

Conversation

@flokli

@flokli flokli commented May 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@flokli flokli requested a review from alyssais May 15, 2025 13:42
@github-actions github-actions Bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 15, 2025
alyssais
alyssais previously requested changes May 17, 2025
View reviewed changes
Comment thread pkgs/by-name/ir/irccat/package.nix Outdated
@flokli flokli requested a review from alyssais May 18, 2025 11:58
@flokli

flokli commented May 19, 2025

Copy link
Copy Markdown
Member Author

irccloud/irccat#38 got merged upstream, so we don't need to vendor the patch anymore.

@flokli flokli marked this pull request as draft May 19, 2025 10:31
@flokli flokli marked this pull request as ready for review May 19, 2025 13:42
@flokli

flokli commented May 19, 2025

Copy link
Copy Markdown
Member Author

Upstream tagged a release containing the fix, so I updated this to 0.4.12, PTAL

@alyssais alyssais merged commit 4612572 into NixOS:master May 20, 2025
29 of 31 checks passed
@flokli flokli deleted the irccat branch May 20, 2025 11:37
@nixpkgs-ci

nixpkgs-ci Bot commented May 20, 2025

Copy link
Copy Markdown
Contributor

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci Bot mentioned this pull request May 20, 2025
Merged
1 task
@nixpkgs-ci nixpkgs-ci Bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssais alyssais Awaiting requested review from alyssais

Assignees

No one assigned

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@flokli @alyssais