surge-downloader: init at 0.12.1

[ErmitaVulpe]

Added surge, a TUI download manager. Sadly the name surge was already taken so I added it as surge-downloader.

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

[acid-bong]

and obv squash commits (last two only), new files are supposed to be added in one go

[ErmitaVulpe]

Hey, Just checking in. I’ve addressed all the previous review comments and re-requested review. Would appreciate a look when you have time

[ErmitaVulpe]

Since it's been a while, I updated the package to 0.6.8 and added a passthru.updateScript

[ErmitaVulpe]

@acid-bong

[lukasgierth]

Any progress here?

[ErmitaVulpe]

The package is done. All I can do is just update the version. Someone with merge permissions needs to press the button. For now you can just use an overlay with this package.nix. Just update its version if you'll do that.

[phanirithvij]

Thanks for the changes, final review.

[ErmitaVulpe]

Damn good catch. I didn't look into the resulting bin dir. It turns out that that go executable is related to the browser extension. I added subPackages = [ "." ]; to build just the cmd, and got rid of the writableTmpDirAsHomeHook since it was the extensions tests that required it. I assume this is also true for the local server?

[phanirithvij]

On darwin it is case insensitive, so I think we should skip the installPhase for darwin.

[ErmitaVulpe]

✅ nixpkgs-review result

Generated using nixpkgs-review-gha (85fc054)

Command: nixpkgs-review pr 488785
Commit: 02353e176cab9a64aa76d4192c83e77a7bed9e7a (subsequent changes)
Merge: 290092e9f821ae04c17f4b09a211fd3862192851

Logs: https://github.com/ErmitaVulpe/nixpkgs-review-gha/actions/runs/33156425949/attempts/4

---

x86_64-linux

✅ 1 package built:

• surge-downloader

---

aarch64-linux

✅ 1 package built:

• surge-downloader

---

aarch64-darwin (sandbox = true)

✅ 1 package built:

• surge-downloader

[drupol]

Why not this ?

Suggested change

	mv $out/bin/Surge $out/bin/surge.tmp
	mv $out/bin/surge.tmp $out/bin/surge
	mv $out/bin/Surge $out/bin/surge

[phanirithvij]

On macOS that didn't work. https://github.com/phanirithvij/nixpkgs-review-gha/actions/runs/33111895418/job/98656642569#step:6:860

The filesystem is case insensitive.