openshadinglanguage: remove libclang as shared lib - #546530
Open
amarshall wants to merge 2 commits into
Open
Conversation
Removing these seems to cause no build issues or issues using in Blender. `clang` in nativeBuildInputs should be redundant since `LLVM_BC_GENERATOR` is set explicitly.
This seems unnecessary since build succeeds, and OSL render in Blender also succeeds. It is necessary since adding libclang-cpp.so pulls in libLLVM, which we are trying to avoid with LLVM_STATIC since it causes libLLVM conflicts downstream in e.g. `pkgsRocm.blender`. See NixOS#530702.
amarshall
marked this pull request as ready for review
July 28, 2026 02:59
amarshall
commented
Jul 28, 2026
Member
Author
There was a problem hiding this comment.
I would like to better understand why upstream does this, and why we don’t need it even in “shared” mode (admittedly I don’t get it), to see if this or something similar can be upstreamed. Needs investigation though and that may take some time.
nixpkgs-ci
Bot
added
10.rebuild-linux: 11-100
4 tasks
Member
Author
|
nixpkgs-ci
Bot
removed
the
9.needs: reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit msgs for details.
Fixes #530702
Things done
Built
pkgsRocm.blenderand tested HIP GPU render and OSL CPU render.passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.