moonshine: 0.13.5 -> 0.14.0

[ap-1]

changelog

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.
• Follows the automation/AI policy.

[ap-1]

✅ nixpkgs-review result

Generated using nixpkgs-review-gha (d38b08f)

Command: nixpkgs-review pr 546531
Commit: 3eea1292093c0543379b0259324429668e2e9470 (subsequent changes)
Merge: 6f77e5e91b9f054a1db95293ff08aaaff5b6f4d2

Logs: https://github.com/ap-1/nixpkgs-review-gha/actions/runs/30324812914/attempts/1

---

x86_64-linux

✅ 1 package built:

• moonshine

---

aarch64-linux

✅ 1 package built:

• moonshine

[nixpkgs-review-gha]

✅ nixpkgs-review result

Generated using nixpkgs-review-gha (def992f)

Command: nixpkgs-review pr 546531
Commit: 3eea1292093c0543379b0259324429668e2e9470 (subsequent changes)
Merge: 6f77e5e91b9f054a1db95293ff08aaaff5b6f4d2

Triggered by @coolcuber (35880825)
Logs: https://github.com/coolcuber/nixpkgs-review-gha/actions/runs/30365322722/attempts/1

---

x86_64-linux

✅ 1 package built:

• moonshine

---

aarch64-linux

✅ 1 package built:

• moonshine

---

aarch64-darwin

✅ No rebuilds

[neobrain]

Thanks! Patch looks good and is working fine locally, but it's not a requirement to add yourself to the maintainer list. It would make more sense to add yourself after having done more substantial changes.

Also note there's a weekly auto-update on this package, which is generally a bit easier to review and merge than manual version bumps.

[ap-1]

Thanks! Patch looks good and is working fine locally, but it's not a requirement to add yourself to the maintainer list. It would make more sense to add yourself after having done more substantial changes.

Also note there's a weekly auto-update on this package, which is generally a bit easier to review and merge than manual version bumps.

Thanks for the review! On the maintainer entry, the weekly auto-update is actually the main reason I'd like to be listed. I add myself as a maintainer to packages I use so that I can personally see to getting the r-ryantm PRs merged sooner.

As far as I know there's no prerequisite of prior substantial changes for adopting a package in pkgs/by-name, but let me know if I've missed something. For context, I reviewed your original PR #544596 adding this package, so I'm not picking it up at random.

If there's nothing you'd like changed in the patch itself, could you dismiss the review so this can get merged?

[neobrain]

Ah, I didn't notice the context of the original review.

My personal opinion is that maintainers should at minimum test package binaries before submitting updates, which hasn't happened here. Adding new maintainers just so PRs land a day earlier doesn't seem very effective (especially if it comes at the cost of not testing anything).

As you mention I don't think there are strictly documented requirements for becoming a maintainer, but since I'm not yet familiar with the soft conventions around nixpkgs maintainership I'll defer to my intuition there. My review doesn't block things though, so if other people are happy to add you to the list I don't mind.