feishin: bump electron to v43, clean up

[ShowhyT]

Work towards: #555100

Things done

• rewrite to use finalAttrs
• added a tests
• bump electron version to v43
• basic test passed in NixOS-WSL

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.
• Follows the automation/AI policy.

[ShowhyT]

✅ nixpkgs-review result for #556548

Generated using nixpkgs-review-gha (b38d73c)

Command: nixpkgs-review pr 556548
Commit: 479bff321a9d397712ab4ef3b180be9d32007c1b (subsequent changes)
Merge: f13432ba01c7dcdb0b6b49c009d3b7481ddd0953

Logs: https://github.com/ShowhyT/nixpkgs-review-gha/actions/runs/32903784186/attempts/1

Download packages from cache:

• x86_64-linux

  nix-store -r \
    --option binary-caches 'https://cache.nixos.org/ https://builds.cachix.org' \
    --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      builds.cachix.org-1:628RFN/JZH6b09pwud65gIAvYg9oGIEGIqNPy8cDRU4=
    ' \
    /nix/store/iz5w6smkjgi5qvrqd09y0ryvr3g4xhk1-feishin-1.15.1

• aarch64-linux

  nix-store -r \
    --option binary-caches 'https://cache.nixos.org/ https://builds.cachix.org' \
    --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      builds.cachix.org-1:628RFN/JZH6b09pwud65gIAvYg9oGIEGIqNPy8cDRU4=
    ' \
    /nix/store/qmwch49a0kybhq9hxrhmh7r4rzd66772-feishin-1.15.1

• aarch64-darwin

  nix-store -r \
    --option binary-caches 'https://cache.nixos.org/ https://builds.cachix.org' \
    --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      builds.cachix.org-1:628RFN/JZH6b09pwud65gIAvYg9oGIEGIqNPy8cDRU4=
    ' \
    /nix/store/azkcr6m9acv6im4h4awwibm7qdcbax8j-feishin-1.15.1

---

x86_64-linux

✅ 1 package built:

• feishin

---

aarch64-linux

✅ 1 package built:

• feishin

---

aarch64-darwin (sandbox = true)

✅ 1 package built:

• feishin

[BatteredBunny]

Did you try if electron v43/44 works? Last time iirc the maintainer bumped to latest available electron version jeffvli/feishin#2047

[BatteredBunny]

Imo the commit name should reflect the clean up you did in addition, e.g:

feishin: bump electron to v42; clean up

[onny]

yep please split the changes into separate commits

[ShowhyT]

Did you try if electron v43/44 works? Last time iirc the maintainer bumped to latest available electron version jeffvli/feishin#2047

Tested with v43. The package built and launched successfully.

yep please split the changes into separate commits

Done

[BatteredBunny]

LGTM. Tested on aarch64-darwin

[nixpkgs-ci]

Successfully created backport PR for release-26.05:

• [Backport release-26.05] feishin: bump electron to v43, clean up #557060