Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
github.event.pull_request.title
has backticks, like in this PR, then these actions will fail because bash will try to perform process substitution. See the "Set message" step here:(That step also has a different here-doc related warning that is always shown. It doesn't seem to be important, but I fixed it in this PR anyway).
The solution is to quote the here-doc marker, as explained here:
This means that no substitution whatsoever will happen. This is fine, because we are only using
${{format(...)}}
, which is a GitHub Actions thing, not a bash thing.I'm not sure how to test this though. I guess we can update this:
https://github.com/NomicFoundation/hardhat/blob/411fef632efe130dc55d651708faad7aad3cc021/.github/workflows/review-requested-slack-notification.yml#L7
To use the commit hash in this PR, and then send a test PR to see what happens.