Make #resolveFileAction use the action pluginId instead of the task pluginId

Author: schaable

v-next/core/src/internal/tasks/resolved-task.ts

@@ -130,11 +130,13 @@ export class ResolvedTask implements Task {
     ): Promise<any> => {
       // The first action may be empty if the task was originally an empty task
       const currentAction = this.actions[currentIndex].action ?? (() => {});
-
       const actionFn =
         typeof currentAction === "function"
           ? currentAction
-          : await this.#resolveFileAction(currentAction);
+          : await this.#resolveFileAction(
+              currentAction,
+              this.actions[currentIndex].pluginId,
+            );
 
       if (currentIndex === 0) {
         /* eslint-disable-next-line @typescript-eslint/consistent-type-assertions --
@@ -241,21 +243,22 @@ export class ResolvedTask implements Task {
    */
   async #resolveFileAction(
     actionFileUrl: string,
+    actionPluginId?: string,
   ): Promise<NewTaskActionFunction | TaskOverrideActionFunction> {
     let resolvedActionFn;
     try {
       resolvedActionFn = await import(actionFileUrl);
     } catch (error) {
       ensureError(error);
 
-      if (this.pluginId !== undefined) {
+      if (actionPluginId !== undefined) {
         const plugin = this.#hre.config.plugins.find(
-          (p) => p.id === this.pluginId,
+          (p) => p.id === actionPluginId,
         );
 
         assertHardhatInvariant(
           plugin !== undefined,
-          `Plugin with id ${this.pluginId} not found.`,
+          `Plugin with id ${actionPluginId} not found.`,
         );
 
         await detectPluginNpmDependencyProblems(plugin);

v-next/core/test/internal/tasks/task-manager.ts

@@ -1530,7 +1530,8 @@ describe("TaskManagerImplementation", () => {
           "./fixture-projects/not-installed-package/index.js",
         );
 
-        const hre = await createHardhatRuntimeEnvironment({
+        // the missing dependency is used in the NEW_TASK action
+        let hre = await createHardhatRuntimeEnvironment({
           plugins: [
             {
               id: "plugin1",
@@ -1544,13 +1545,42 @@ describe("TaskManagerImplementation", () => {
           ],
         });
 
-        const task1 = hre.tasks.getTask("task1");
         await assert.rejects(
-          task1.run({}),
+          hre.tasks.getTask("task1").run({}),
           new HardhatError(HardhatError.ERRORS.PLUGINS.PLUGIN_NOT_INSTALLED, {
             pluginId: "plugin1",
           }),
         );
+
+        // the missing dependency is used in the TASK_OVERRIDE action
+        hre = await createHardhatRuntimeEnvironment({
+          plugins: [
+            {
+              id: "plugin1",
+              tasks: [
+                new NewTaskDefinitionBuilderImplementation("task1")
+                  .setAction(() => {})
+                  .build(),
+              ],
+            },
+            {
+              id: "plugin2",
+              npmPackage: "non-installed-package",
+              tasks: [
+                new TaskOverrideDefinitionBuilderImplementation("task1")
+                  .setAction(nonInstalledPackageActionUrl)
+                  .build(),
+              ],
+            },
+          ],
+        });
+
+        await assert.rejects(
+          hre.tasks.getTask("task1").run({}),
+          new HardhatError(HardhatError.ERRORS.PLUGINS.PLUGIN_NOT_INSTALLED, {
+            pluginId: "plugin2",
+          }),
+        );
       });
 
       it("should throw if an action url is provided and the corresponding module doesn't have a default export", async () => {