Skip to content

Commit f57d015

Browse files
authored
Merge pull request #6163 from NomicFoundation/small-comments-improvements
Improve two build-system related comments
2 parents 1e591a6 + 8efa6de commit f57d015

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

v-next/hardhat/src/internal/builtin-plugins/solidity/build-system/build-system.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -263,8 +263,9 @@ export class SolidityBuildSystemImplementation implements SolidityBuildSystem {
263263
DependencyGraphImplementation
264264
> = new Map();
265265

266-
// Note: This is merging solc config object identity, not a deep
267-
// comparison. This is Hardhat v2's behavior.
266+
// Note: This groups the subgraphs by solc config. It compares the configs
267+
// based on reference, and not by deep equality. It misses some merging
268+
// opportunities, but this is Hardhat v2's behavior and works well enough.
268269
for (const [solcConfig, subgraph] of subgraphsWithConfig) {
269270
const mergedSubgraph = mergedSubgraphsByConfig.get(solcConfig);
270271

v-next/hardhat/src/internal/builtin-plugins/solidity/build-system/resolver/dependency-resolver.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ import {
5252
// packages, by forbidding user remappings with context and starting with
5353
// `npm/`.
5454
// - We do allow users to remap imports of non-npm files, including remmapping
55-
// them into file within npm packages.
55+
// them into npm packages.
5656
// - Every import in an npm file is either relative or remapped by a remapping
5757
// generated by the resolver.
5858
// - A direct import (i.e. not relative) is considered to be local within the

0 commit comments

Comments
 (0)