Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename globalParametersMap to globalArgumentDefinitions for clarity #5416

Closed
schaable opened this issue Jun 19, 2024 · 0 comments
Closed

Rename globalParametersMap to globalArgumentDefinitions for clarity #5416

schaable opened this issue Jun 19, 2024 · 0 comments
Assignees
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task

Comments

@schaable
Copy link
Member

The way global parameters are named across the code may be confusing. The collection of global parameter definitions is called globalParametersMap, while the actual values provided by the user are called userProvidedGlobalArguments. To make this clearer, we should rename globalParametersMap to globalArgumentDefinitions. The rename should take into account functions like buildGlobalParametersMap as well, and update variable names in tests, descriptions, and also variables in the hardhat package.

@schaable schaable added the v-next A Hardhat v3 development task label Jun 19, 2024
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jun 19, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Jun 19, 2024
@kanej kanej moved this from Backlog to To-do in Hardhat Jun 20, 2024
@schaable schaable moved this from To-do to In Progress in Hardhat Jul 2, 2024
@schaable schaable self-assigned this Jul 2, 2024
@schaable schaable moved this from In Progress to In Review in Hardhat Jul 2, 2024
@schaable schaable moved this from In Review to Done in Hardhat Jul 4, 2024
@schaable schaable closed this as completed Jul 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Archived in project
Development

No branches or pull requests

1 participant