Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename globalOptionsMap to globalOptionDefinitions #5474

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Rename globalOptionsMap to globalOptionDefinitions #5474

merged 1 commit into from
Jul 4, 2024

Conversation

schaable
Copy link
Member

@schaable schaable commented Jul 2, 2024

Closes #5416
Part of #5420

@schaable schaable added the v-next A Hardhat v3 development task label Jul 2, 2024
@schaable schaable self-assigned this Jul 2, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2024

⚠️ No Changeset found

Latest commit: ecc729d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jul 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 11:09pm

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jul 2, 2024
Base automatically changed from rename-parameterType to v-next July 4, 2024 18:00
@schaable schaable merged commit 984091f into v-next Jul 4, 2024
51 checks passed
@schaable schaable deleted the rename-globalParametersMap branch July 4, 2024 18:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alcuadrado alcuadrado alcuadrado approved these changes

@ChristopherDedominici ChristopherDedominici Awaiting requested review from ChristopherDedominici

Assignees

@schaable schaable

Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schaable @alcuadrado