Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests for validation errors in the network manager #6198

Open
schaable opened this issue Jan 28, 2025 · 0 comments · Fixed by #6480
Open

Improve tests for validation errors in the network manager #6198

schaable opened this issue Jan 28, 2025 · 0 comments · Fixed by #6480
Assignees
@zoeyTM
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Milestone
Public Alpha Feat...

Comments

@schaable
Copy link
Member

Rework the tests to use assertValidationErrors and add any missing test cases.
@schaable schaable added the v-next A Hardhat v3 development task label Jan 28, 2025
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jan 28, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Jan 28, 2025
@schaable schaable mentioned this issue Jan 30, 2025
Merged
@kanej kanej moved this from Backlog to To-do in Hardhat Feb 24, 2025
@kanej kanej added this to the Public Alpha Feature Rollout milestone Feb 24, 2025
@zoeyTM zoeyTM self-assigned this Mar 6, 2025
@kanej kanej moved this from To-do to In Progress in Hardhat Mar 14, 2025
@zoeyTM zoeyTM mentioned this issue Mar 17, 2025
Merged
@zoeyTM zoeyTM moved this from In Progress to In Review in Hardhat Mar 17, 2025
@zoeyTM zoeyTM linked a pull request Mar 17, 2025 that will close this issue
Restructure validation tests and add tests for missing fields #6480
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zoeyTM zoeyTM

Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Hardhat
Status: In Review
Milestone
Public Alpha Feature Rollout
Development

Successfully merging a pull request may close this issue.

Restructure validation tests and add tests for missing fields NomicFoundation/hardhat
3 participants
@kanej @schaable @zoeyTM