Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure validation tests and add tests for missing fields #6480

Open
wants to merge 1 commit into
base: v-next
Choose a base branch
from
Open

Restructure validation tests and add tests for missing fields #6480

wants to merge 1 commit into from
+1,833 −314

Conversation

zoeyTM
Copy link
Contributor

@zoeyTM zoeyTM commented Mar 17, 2025

resolves #6198

@vercel Vercel
Copy link

vercel bot commented Mar 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 4:25am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 398204b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zoeyTM zoeyTM requested a review from schaable March 17, 2025 23:18
@zoeyTM zoeyTM added no changeset needed This PR doesn't require a changeset and removed status:triaging labels Mar 17, 2025
@zoeyTM zoeyTM linked an issue Mar 17, 2025 that may be closed by this pull request
Improve tests for validation errors in the network manager #6198
Open
@zoeyTM zoeyTM added the v-next A Hardhat v3 development task label Mar 17, 2025
schaable
schaable approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@schaable schaable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left 2 small comments, but consider it approved.

@zoeyTM zoeyTM force-pushed the improvement/network-manager-validation-tests branch from c7e4bae to 398204b Compare March 20, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schaable schaable schaable approved these changes

Assignees
No one assigned
Labels
no changeset needed This PR doesn't require a changeset v-next A Hardhat v3 development task
Projects
Hardhat
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve tests for validation errors in the network manager
3 participants
@zoeyTM @schaable @kanej