Accept Typed object in matcher

[RenanSouza2]

Resolves #4716

• Because this PR includes a bug fix, relevant tests have been included.

This PR expands the reccently added feature of accepting multiple forms of address in the macthers

It now accpets objects created by ethers.Typed.address()

[changeset-bot]

🦋 Changeset detected

Latest commit: 72bf9f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@nomicfoundation/hardhat-chai-matchers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hardhat	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 31, 2024 11:12am

[fvictorio]

Thanks @RenanSouza2, and sorry for taking so long to get this merged. I found a problem with one of our custom linting rules when I reviewed it (#4786), so we wanted to get that fixed first.

[fvictorio]

Ah, also: I removed one of the tests, because I think it was just encoding a limitation (that 2 and typed 2 cannot be compared). Since that's more of a lack of a feature than a decision, I think it shouldn't be represented in a test. But please let me know if you disagree!

[RenanSouza2]

Thanks @RenanSouza2, and sorry for taking so long to get this merged. I found a problem with one of our custom linting rules when I reviewed it (#4786), so we wanted to get that fixed first.

No problems about that :)

Ah, also: I removed one of the tests, because I think it was just encoding a limitation (that 2 and typed 2 cannot be compared). Since that's more of a lack of a feature than a decision, I think it shouldn't be represented in a test. But please let me know if you disagree!

That test was to assure it was not rejecting all other Typed objects.

At first I used the ethers dereference function dereference directly and that function throws an error when you pass a different type other than the one stored at the typed object

that test had a use but I don't see that much of a deal removing it

[fvictorio]

Hmm, I'm not sure I understand. This was the test:

  it("should accept other typed objects", async function () {
    expect(() => {
      expect(2).to.equal(ethers.Typed.uint256(2));
    }).to.throw("expected 2 to equal");
  });

But I would actually expect that assertion to pass, not to throw. I mean: asserting that expect(2).to.equal(Typed.uint256(2)) fails seems to be testing that something that ideally would work doesn't actually work. Does that make sense?