Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing hardhat-foundry combined setup page #4782

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

Genesis3800
Copy link
Contributor

Hey @fvictorio apologies for being so delayed, but I am pushing a PR to fix an error at the docs as acknowledged in issue #4606 .

I came across this issue while writing this article for the official foundry book, which is now merged:
https://book.getfoundry.sh/config/hardhat

The second section of the article inside Hardhat's docs should now work out of the box.

Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 9:04am

Copy link

changeset-bot bot commented Jan 23, 2024

⚠️ No Changeset found

Latest commit: 1140eee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fvictorio
Copy link
Member

Thanks!

@fvictorio fvictorio merged commit 109a6d9 into NomicFoundation:main Feb 8, 2024
3 of 4 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants