Skip to content

chore: replace unmaintained eslint-plugin-node with eslint-plugin-n #4926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stefanosala
Copy link
Contributor

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

Ref: #4824

I was exploring the hardhat repo and thought about picking a couple of low hanging fruits to get to know the repository and the team :) this one seemed to be quite straightforward? Do you need me to update anything else?

Thanks!
Stefano

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:01pm

Copy link

changeset-bot bot commented Feb 22, 2024

⚠️ No Changeset found

Latest commit: 73a9cfb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@stefanosala stefanosala marked this pull request as draft February 22, 2024 15:55
@stefanosala stefanosala marked this pull request as ready for review February 22, 2024 16:23
@kanej kanej added status:ready This issue is ready to be worked on and removed status:triaging labels Feb 23, 2024
@kanej kanej removed their assignment Mar 8, 2024
@alcuadrado alcuadrado added the no changeset needed This PR doesn't require a changeset label May 9, 2024
@stefanosala
Copy link
Contributor Author

Happy to see a progress here, thanks @alcuadrado :)

@alcuadrado
Copy link
Member

alcuadrado commented May 9, 2024

Sorry it took so long. I'll merge it as soon as the ci passes.

@stefanosala
Copy link
Contributor Author

No worries! It was my effort in trying to get used to the code / repo as quickly as possible back when I was in the process of interviewing with Nomic :)

@alcuadrado alcuadrado merged commit 309cf46 into NomicFoundation:main May 9, 2024
27 checks passed
@stefanosala stefanosala deleted the feature/eslint-plugin-n branch May 9, 2024 19:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants