Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci fixes #4967

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Ci fixes #4967

merged 6 commits into from
Mar 7, 2024

Conversation

fvictorio
Copy link
Member

@fvictorio fvictorio commented Mar 6, 2024 •
edited
Loading

See individual commits for the details.

I ran the pre-release workflow on this branch to verify that it works; check the results here.

fvictorio added 4 commits March 6, 2024 14:40
@fvictorio
Don't run the release workflow on pull requests
a648dbf 
The "Check commit" job fails in pull requests from external users. The
easiest fix is to just not run it in pull requests. Since this workflow
is about publishing, it makes sense to only run it in `main` (and
`edr/release`, for special cases). The downside is that the sanity
checks that are performed at the beginning won't run in pull requests,
but this seems like an acceptable trade-off for now.
@fvictorio
Allow publishing EDR from the edr/release branch
0d8471f 
Useful when we want to publish a pre-release and for any reason we don't
want to merge it to main.
@fvictorio
Run recent mainnet block workflow every 8 hours
a3e0c06
@fvictorio
Make pre-release workflow work with EDR
992d5b5
@fvictorio fvictorio requested review from kanej and agostbiro March 6, 2024 13:49
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7743102

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 0:39am

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Mar 6, 2024
@fvictorio fvictorio added the no changeset needed This PR doesn't require a changeset label Mar 6, 2024
agostbiro
agostbiro requested changes Mar 6, 2024
View reviewed changes
@fvictorio fvictorio merged commit e423f25 into main Mar 7, 2024
30 checks passed
@fvictorio fvictorio deleted the ci-fixes branch March 7, 2024 15:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agostbiro agostbiro agostbiro approved these changes

@kanej kanej Awaiting requested review from kanej

Assignees
No one assigned
Labels
no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fvictorio @agostbiro