Use remote chain id in fork metadata #5114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3d7f13e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fvictorio
had a problem deploying
to
github-action-benchmark
GitHub Actions
Error
fvictorio
commented
Apr 12, 2024
fvictorio
commented
Apr 12, 2024
| let fixture = ProviderTestFixture::new_forked(None)?; | ||
|
|
||
| let fork_metadata = fixture.provider_data.fork_metadata().unwrap(); | ||
| assert_eq!(fork_metadata.chain_id, 1); |
There was a problem hiding this comment.
Is it ok to assume that we are forking mainnet here? I think it is, but would like to get confirmation.
If it's not ok, is there an example of a test where we are doing this "correctly"?
There was a problem hiding this comment.
We assume this everywhere else in the code, so I think it's fine.
Wodann
approved these changes
Apr 12, 2024
fvictorio
had a problem deploying
to
github-action-benchmark
GitHub Actions
Error
fvictorio
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
agostbiro
approved these changes
Apr 12, 2024
fvictorio
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
Wodann
approved these changes
Apr 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes NomicFoundation/edr#366